Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Bug #2117 #2867

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

erdoking
Copy link

@erdoking erdoking commented May 5, 2020

"#2117 [Backup] If server saves point to ${HOME} they may not be backed up"

This fix makes the backup include the savegames also on non standard installations.
Checked with sdtd.

"GameServerManagers#2117 [Backup] If server saves point to ${HOME} they may not be backed up"

This fix makes the backup include the savegames also on non standard installations.
Checked with sdtd.
@dgibbs64
Copy link
Member

Different game servers may have different save locations within HOME so this fix may not work with all game servers. I will take a look at this when I do planned backup refactor. I will hold this fix until then.

Thanks for creating this PR

@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@dgibbs64 dgibbs64 reopened this Jan 27, 2021
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Jan 28, 2021
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from f02e53d to 2257be4 Compare October 22, 2022 21:53
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64 dgibbs64 force-pushed the develop branch 2 times, most recently from 7a72c04 to f28a4e5 Compare December 3, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch conflicts Branch of pr has conflicts that need to be worked on command: backup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants