Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix (Consider this as one :)] Change MacOS shortcut from "Shift-Tab" to "Option-Tab" #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhengliw
Copy link

@zhengliw zhengliw commented Nov 24, 2022

Context

Really, it is just that simple as in the title. I found it extremely inconvienient to have Shift-Tab instead of something better for launching DropPoint on MacOS. Shift-Tab is commonly used by code editors in order to deindent code, as you know :)

Description of the Change

Only one line of code was changed.

if (process.platform === "darwin") {
    //caps lock is not a modifier in mac
    // old: shortcut = "Shift+Tab";
    // new: shortcut = "Option+Tab";

Alternate Designs

Instead of this solution, add an option in the upcoming settings panel to allow customized launching shortcuts.

Possible Drawbacks

Users who have gotten used to Shift-Tab may find it a bit confusing, but I assume that there are no worse negative impacts.

Verification Process

I have built it with Electron and tested it out. This shortcut worked perfectly fine.

Release Notes

  • Changed the MacOS launching shortcut from "Shift-Tab" to "Option-Tab"

@zhengliw
Copy link
Author

Thank you for this amazing app! And thank you to the supporting community!

@tflo
Copy link

tflo commented Jul 23, 2023

Please implement this PR. As the OP says, Shift-Tab is used for de-indenting in most text editors, and makes this nice little app unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants