Use find_package(Python) instead of PythonInterp #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently find_package(PythonInterp) is deprecated since 3.12.
|
CGAL-5.3 will require CMake >= 3.14, so I think it would be fine if Gudhi-3.5 did as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently find_package(PythonInterp) is deprecated since 3.12. However, this patch requires cmake >= 3.12, which may be a bit too recent (1 year old next week)...
It is also a bit less convenient to specify a non-default version of python (I have 3.8 and 3.7, but only 3.7 has the various modules installed): I first run cmake (it picks python3.8, the most recent), then edit the python executable with ccmake, and let it configure/generate.
Fix #139.