Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindPythonInterp deprecated #139

Open
mglisse opened this issue Nov 10, 2019 · 1 comment 路 May be fixed by #151 or #1007
Open

FindPythonInterp deprecated #139

mglisse opened this issue Nov 10, 2019 · 1 comment 路 May be fixed by #151 or #1007
Labels
build The build system (CMake, etc) cmake3.12 Requires CMake >= 3.12

Comments

@mglisse
Copy link
Member

mglisse commented Nov 10, 2019

With cmake-3.12 or more recent

find_package(PythonInterp)

should be replaced with

find_package(Python COMPONENTS Interpreter)

As a bonus, this picks python3 over python2 by default 馃槈
@mglisse mglisse added the build The build system (CMake, etc) label Nov 15, 2019
@mglisse mglisse linked a pull request Nov 21, 2019 that will close this issue
Draft
@VincentRouvreau VincentRouvreau added the cmake3.12 Requires CMake >= 3.12 label Mar 4, 2022
@VincentRouvreau VincentRouvreau linked a pull request Nov 29, 2023 that will close this issue
Draft
@VincentRouvreau
Copy link
Contributor

CMake 3.12 release date is november 2018.
With recent CMake version (3.29.2), a warning is displayed:

CMake Warning (dev) at src/cmake/modules/GUDHI_third_party_libraries.cmake:130 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build system (CMake, etc) cmake3.12 Requires CMake >= 3.12
Projects
None yet
Milestone
No milestone
2 participants
@mglisse @VincentRouvreau