Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP focus setting for modal open and close #785

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iamjolly
Copy link
Member

@iamjolly iamjolly commented Feb 3, 2022

For @ryanwoldatwork and @iamjolly to pair on.

Relates to #480

Things to do:

  • Set focus on modal div when opened
  • Set focus back to touchpoints button when modal is closed
  • Confirm listener for esc keypress to run the handleDialogClose function.
  • Trap focus in modal when opened - see Using JavaScript to trap focus in an element for more info
  • Test with keyboard only and with screen reader to confirm everything works as expected.

Note: This is a vanilla JS approach to adding accessibility to the modal. A next effort should involve looking at ways for touchpoints to use the USWDS modal component per #481.

Signed-off-by: Robert Jolly <robert.jolly@gsa.gov>
@ryanwoldatwork
Copy link
Collaborator

thanks @iamjolly!!

@ryanwoldatwork
Copy link
Collaborator

paired today and check a few boxes here

@cannandev
Copy link

Hey @iamjolly @ryanwoldatwork I'm working on a project that would implement Touchpoints on childcare.gov. Wanted to check in on the status of this update. Thanks in advance!

@ryanwoldatwork
Copy link
Collaborator

hi @cannandev - the path forward is pretty clear. Hoping to knock this out late next week.

@mharvey
Copy link

mharvey commented Nov 16, 2022

@iamjolly , @ryanwoldatwork : Could you please provide a status update on this? Thanks!

@ryanwoldatwork ryanwoldatwork force-pushed the develop branch 18 times, most recently from 8bdac6b to 82c3091 Compare March 24, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants