Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-5151 Hide old SERP settings in Super Admin and Admin Center #1567

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ddzz
Copy link
Contributor

@ddzz ddzz commented May 10, 2024

⚠️ DO NOT MERGE UNTIL https://cm-jira.usa.gov/browse/SRCH-4862 IS DEPLOYED ⚠️

Summary

Checklist

Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the ⚠️ :warning: emoji and explain why the step was not completed.

Functionality Checks

  • You have merged the latest changes from the target branch (usually main) into your branch.

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.

  • Automated checks pass. If Code Climate checks do not pass, explain reason for failures:

Process Checks

  • You have specified at least one "Reviewer".

@ddzz ddzz marked this pull request as ready for review May 10, 2024 17:36
@ddzz ddzz requested a review from stevenbarragan May 10, 2024 17:36
@ddzz
Copy link
Contributor Author

ddzz commented May 14, 2024

⚠️ DO NOT MERGE UNTIL https://cm-jira.usa.gov/browse/SRCH-4862 IS DEPLOYED ⚠️

Copy link
Contributor

@stevenbarragan stevenbarragan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants