Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursive_delete, add prevent_destroy #926

Draft
wants to merge 2 commits into
base: jskinne3-sandbox-space
Choose a base branch
from

Conversation

jskinne3
Copy link
Contributor

Description

Modernize the notation for allowing delete / destroy of sandbox resources. This will prove the method to prevent delete / destroy in higher deployed environments.

  • remove deprecated recursive_delete argument
  • substitute prevent_destroy argument

馃槙 Oddity: Because the lifecycle block does not accept variables I eliminated the local variable that controlled deleting.

Deployment

This branches off of #925 which in turn is dependent upon #923

鈿狅笍 Do not merge until 923 and 925 have both been merged, deployed, and validated

@jskinne3 jskinne3 requested review from ccostino and a team April 17, 2024 00:05
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jskinne3! Same note as the other PR, we'll have to rebase this first once the initial batch of PRs are merged to make sure this is up-to-date.

@jskinne3 jskinne3 marked this pull request as draft April 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants