Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add webkit #1434

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

add webkit #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
005088f
add webkit
Apr 17, 2024
17640b4
try flask debug
Apr 17, 2024
d0fd6be
try flask debug
Apr 17, 2024
0abb6b8
try with npx
Apr 17, 2024
ef68047
try with npx
Apr 17, 2024
1c2a4ef
try with npx
Apr 17, 2024
41a8784
try with npx
Apr 17, 2024
462fc13
debug
Apr 17, 2024
3d9346e
try landing on accounts page
Apr 17, 2024
c9d3002
try landing on accounts page
Apr 17, 2024
df710f4
try npx
Apr 18, 2024
5c40d1c
try npx again
Apr 18, 2024
e705dd6
fix up
Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ bootstrap: generate-version-file ## Set up everything to run the app
poetry self add poetry-dotenv-plugin
poetry lock --no-update
poetry install --sync --no-root
poetry run playwright install --with-deps
poetry run pre-commit install
poetry run playwright install
poetry run playwright install-deps
source $(NVMSH) --no-use && nvm install && npm ci --no-audit
source $(NVMSH) && npm run build

Expand Down Expand Up @@ -82,7 +83,7 @@ dead-code:
.PHONY: e2e-test
e2e-test: export NEW_RELIC_ENVIRONMENT=test
e2e-test: ## Run end-to-end integration tests; note that --browser webkit isn't currently working
poetry run pytest -vv --browser chromium --browser firefox tests/end_to_end
poetry run pytest -vv --browser chromium --browser webkit --browser firefox tests/end_to_end

.PHONY: js-lint
js-lint: ## Run javascript linting scanners
Expand Down
56 changes: 56 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"license": "CC0",
"homepage": "https://github.com/GSA/notifications-admin#readme",
"dependencies": {
"@playwright/test": "^1.43.1",
"@uswds/uswds": "^3.4.1",
"cbor-js": "0.1.0",
"govuk_frontend_toolkit": "8.1.0",
Expand Down
9 changes: 4 additions & 5 deletions tests/end_to_end/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,15 @@ def end_to_end_context(browser):
def authenticated_page(end_to_end_context):
# Open a new page and go to the site.
page = end_to_end_context.new_page()
page.goto(f"{E2E_TEST_URI}/")
page.goto(f"{E2E_TEST_URI}/sign-in")

# Wait for the next page to fully load.
page.wait_for_load_state("domcontentloaded")
# page.wait_for_load_state("domcontentloaded")

# Sign in to the site - E2E test accounts are set to flow through.
sign_in_button = page.get_by_role("link", name="Sign in")
sign_in_button.click()
# sign_in_button = page.get_by_role("link", name="Sign in")
# sign_in_button.click()

# Wait for the next page to fully load.
page.wait_for_load_state("domcontentloaded")

return page