Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize notification_utils to the Admin! #1391

Closed
wants to merge 1 commit into from
Closed

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Apr 5, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This changeset copies everything in notifications_utils to turn into a local project module. It includes dependency changes to account for this adjustment and the notifications_utils tests. It also fixes all of the import statements.

TODO

  • Fix the breaking tests
  • Pull in Flask upgrade when it's ready
  • Run through a few more tests to make sure the Admin is fully functional
  • Create a follow-up issue to use vulture . --min-confidence=50 to identify things we can remove from the Admin

Security Considerations

  • We're aiming to reduce development churn by incorporating this code directly and then removing all of the pieces we no longer need in this repo.

This changeset copies everything in notifications_utils to turn into a local project module.  It includes dependency changes to account for this adjustment and the notifications_utils tests.  It also fixes all of the import statements.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
@ccostino ccostino added engineering dependencies Pull requests that update a dependency file labels Apr 5, 2024
@ccostino ccostino self-assigned this Apr 5, 2024
@ccostino ccostino marked this pull request as draft April 5, 2024 16:52
@ccostino
Copy link
Contributor Author

Closing this in favor of #1542!

@ccostino ccostino closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file engineering
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant