update aws sdk and image uploader

[RileySeaburg]

Summary

Replaces outdate gulp-s3-upload package with awspublish package and closes #7554.

Solution

How To Test

1. Add an image(s) and static file to /content/uploads/_inbox/
2. Run npx gulp upload
3. Upload to S3 after processing

---

Dev Checklist

• PR has correct labels
• A11y testing (voice over testing, meets WCAG, run axe tools)
• Code is formatted properly

[RileySeaburg]

This is just to trigger a build with AWS credentials

[RileySeaburg]

Ready for review

[RileySeaburg]

Addresses the feedback, tested and verified to work locally. @nick-mon1

[RileySeaburg]

This pull request also contains the fix for this Security Issue

https://github.com/GSA/digitalgov.gov/security/dependabot/43

$ npm list lodash.trim
digitalgov.gov@2.0.0 /home/riley/programming/digitalgov.gov
└── (empty)

[mejiaj]

@RileySeaburg

I've updated my .env file with the new key names.

Following the testing steps in description:

How To Test

1. Add an image(s) and static file to /content/uploads
2. Run npm gulp upload
   3.Upload to S3 after processing

I get the following error:

➜ npx gulp upload
[15:25:36] Using gulpfile ~/web/digitalgov.gov/gulpfile.js
[15:25:36] Starting 'upload'...
[15:25:36] Starting 'fileTidy'...
[15:25:36] Finished 'fileTidy' after 383 μs
[15:25:36] Starting 'cleanInbox'...
[15:25:36] Finished 'cleanInbox' after 4.53 ms
[15:25:36] Starting 'writeDataFile'...
[15:25:36] Finished 'writeDataFile' after 6.52 ms
[15:25:36] Starting 'processImages'...
[15:25:36] Finished 'processImages' after 228 μs
[15:25:36] Starting 'removeProcessedImage'...
Removing processed images
No images to process
Error processing file: [undefined]. ENOENT: no such file or directory, scandir './content/uploads/_working-images/to-process'
[15:25:36] Finished 'removeProcessedImage' after 882 μs
[15:25:36] Starting 'uploadImage'...
[15:25:36] Finished 'uploadImage' after 3.62 ms
[15:25:36] Starting 'uploadFile'...
[15:25:36] Finished 'uploadFile' after 1.08 ms
[15:25:36] Starting 'cleanup'...
cleanup
[15:25:36] Finished 'cleanup' after 990 μs
[15:25:36] Finished 'upload' after 20 ms

The image needs to be in /content/uploads/_inbox. That runs successfully:

➜ npx gulp upload
[15:29:23] Using gulpfile ~/web/digitalgov.gov/gulpfile.js
[15:29:23] Starting 'upload'...
[15:29:23] Starting 'fileTidy'...
[15:29:23] Finished 'fileTidy' after 380 μs
[15:29:23] Starting 'cleanInbox'...
[15:29:23] Finished 'cleanInbox' after 5.78 ms
[15:29:23] Starting 'writeDataFile'...
[15:29:23] Finished 'writeDataFile' after 9.38 ms
[15:29:23] Starting 'processImages'...
[15:29:23] Finished 'processImages' after 234 μs
[15:29:23] Starting 'removeProcessedImage'...
Removing processed images
[15:29:23] Finished 'removeProcessedImage' after 2.7 ms
[15:29:23] Starting 'uploadImage'...
file is written
[15:29:24] [create] test-dg-s3-upload-pr-7498.png
[15:29:24] [create] test-dg-s3-upload-pr-7498_w200.png
[15:29:24] [create] test-dg-s3-upload-pr-7498_w400.png
[15:29:25] [create] test-dg-s3-upload-pr-7498_w800.png
[15:29:25] Finished 'uploadImage' after 1.42 s
[15:29:25] Starting 'uploadFile'...
[15:29:25] Finished 'uploadFile' after 3.25 ms
[15:29:25] Starting 'cleanup'...
cleanup
[15:29:25] Finished 'cleanup' after 3.8 ms
[15:29:25] Finished 'upload' after 1.45 s

Unfortunately, I still don't see my files in the S3 bucket.

This is the image I'm testing - test-dg-s3-upload-pr-7498.png.

[RileySeaburg]

I'll dive into this tomorrow. Thanks @mejiaj

[nick-mon1]

✅ I was able to successfully upload an image and see it on digitalgov bucket. But no go for uploading files, see my suggestion for getting around the InvalidBucketName: Bucket name shouldn't contain '/', received 'digitalgov/static' error.

[nick-mon1]

When uploading an image, I don't see the content/uploads/_working-images removed. I updated the code to remove the directory instead of the files.

Suggested change

	function cleanup() {
	console.log("cleanup");
	return del([
	"content/uploads/_working-images/**",
	"content/uploads/_working-files/**",
	]);
	}
	function cleanup() {
	console.log("cleanup");
	return del([
	"content/uploads/_working-images",
	"content/uploads/_working-files",
	]);
	}

[nick-mon1]

I still get InvalidBucketName: Bucket name shouldn't contain '/', received 'digitalgov/static'. The solution looks to be renaming the file to include static/filename.pptx before uploading.

We should remove line 31 and try using gulp-rename to include the path in the filename.