Scrolling bug in HCD left nav menu #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a development mode that allows easier debugging of JavaScript
RileySeaburg
added
Dev: frontend
|
@nick-mon1 this is all set. |
nick-mon1
changed the title
ToniBonittoGSA
previously approved these changes
May 14, 2024
nick-mon1
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the guide sidenav styling bug discovered in #7544.
Preview
Link to Preview
Solution
Refactored code to use
getBoundingClientRect.topwithwindow.scrollYto get the distance from the top of the page for each heading to apply the highlight style.How To Test
Dev Checklist