New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create guides landing page #7550
base: main
Are you sure you want to change the base?
Conversation
@nick-mon1 overall looks good... the cards do seem a bit big i wonder if reducing the size is helpful? im happy to talk it through it but also is a personal thing and dont think it should hold up the work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pages look good. I didn't find any a11y issues when running AXE extension.
Posted some comments/questions below.
@bonnieAcameron I've updated the casing for the guide titles in the original markdown files which means that each of the guide landing pages will now reflect the above changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also adjust the padding on the dg-guides.usa.section to .5rem padding on the top? The space there is a little large.
@bonnieAcameron should "human-centered design" also be lowercase in the title for that guide? I would also recommend: "Accessibility for teams" Also, just a personal peference, but i would recommend replacing the second "to" with "and in the "Understanding robotic process automation" blurb: cc @nick-mon1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a capitalization question that we should run by @bonnieAcameron : Should "human-centered design" also be lowercase in the title for that guide? I would also recommend: "Accessibility for teams"
Also, just a personal peference, but i would recommend replacing the second "to" with "and in the "Understanding robotic process automation" blurb:
Configure bots to execute repetitive tasks and save users from performing mundane tasks repeatedly for the same process.
from bonnie comments
Fixing capitalization
fixed capitalization
adjusting wording to avoid repetition of "to"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed a few small text changes for capitalization and to polish intro blurbs.
@@ -1,7 +1,7 @@ | |||
--- | |||
date: 2023-07-24 09:00:00 -0500 | |||
kicker: HCD Guide Series | |||
title: "Introduction to human-centered design" | |||
title: "Introduction to Human-Centered Design" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Human-Centered Design" should remain lowercase: "human-centered design"
Summary
Adds the landing page for the guides section.
Screenshot
Preview
Link to Preview
Solution
dg-guides
anddg-guides-card
component classes for displaying each guideguide_weight
to each guide to display ASC order (lowest to highest)How To Test
Content
@bonnieAcameron Here are some outstanding content related items:
guide_weight
to change order, 1 will display firstDev Checklist