Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024-04-18-uswds-monthly-call-april-2024.md #7546

Merged
merged 9 commits into from May 13, 2024

Conversation

sarah-sch
Copy link
Contributor

@sarah-sch sarah-sch commented May 2, 2024

Updating April 2024 monthly call page event to include script.

Preview

Link to Preview (After)

Link to current state (Before)

Solution

How To Test

  1. Compare the preview to the April 2024 monthly call script to make sure all content is accounted for, including formatting
  2. Ensure that accordion component works.

Dev Checklist

  • PR has correct labels
  • A11y testing (voice over testing, meets WCAG, run axe tools)
  • Code is formatted properly

Updating April 2024 monthly call page event to include script.
@sarah-sch sarah-sch self-assigned this May 2, 2024
@sarah-sch sarah-sch added this to In Production in Digital.gov Content via automation May 2, 2024
Copy link

github-actions bot commented May 2, 2024

🔍 Preview in Federalist

@sarah-sch
Copy link
Contributor Author

@jdotyoon and @nick-mon1 - adding you as peer reviewers to this PR where I added the April MC script in an accordion on the event page. Thank you!

nick-mon1
nick-mon1 previously approved these changes May 3, 2024
Copy link
Contributor

@nick-mon1 nick-mon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sarah-sch

jdotyoon
jdotyoon previously approved these changes May 6, 2024
Copy link
Contributor

@jdotyoon jdotyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Sarah!

Making changes provided by Toni 5/7 and a few other small improvements.
@sarah-sch sarah-sch dismissed stale reviews from jdotyoon and nick-mon1 via 53725cc May 9, 2024 21:43
@nick-mon1 nick-mon1 self-requested a review May 10, 2024 15:26
@ToniBonittoGSA ToniBonittoGSA merged commit 5997db4 into main May 13, 2024
4 checks passed
@ToniBonittoGSA ToniBonittoGSA deleted the ss-april-uswds-mc-script branch May 13, 2024 14:45
Digital.gov Content automation moved this from In Production to Published week 18 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Digital.gov Content
  
Published week 18
Development

Successfully merging this pull request may close these issues.

None yet

4 participants