Added logic to set href for service link

[nick-mon1]

Summary

Visiting https://digital.gov/services/ and clicking each link will take back to the top of the page.
It should link to the external or internal service.

Preview

Link to Preview

Solution

Added logic to properly set the link for each card-service.

  {{- $href := "" -}}

  {{ if .Params.source_url }}
    {{ $href = .Params.source_url }}
  {{ else }}
    {{ $href = .Params.url }}
  {{ end }}

How To Test

All links point to an external page except U.S. Digital Registry and the DAP guide.

---

Dev Checklist

• PR has correct labels
• A11y testing (voice over testing, meets WCAG, run axe tools)
• Code is formatted properly

[github-actions]

🔍 Preview in Federalist

[clmedders]

LGTM - all links are leading to the excited external site and are not sending me to the top of the page

[sarah-sch]

The U.S. Digital Registry link isn't working--is that because it's an internal link and gets messed up in the federalist preview? Otherwise looks good--the bug that was reported has been fixed.

[mejiaj]

@nick-mon1 if one case is more common than others, would it make more sense to set that as the default?

Pseudocode example

// Save the fallback.
{{ $fallback_url := .Params.source_url }}

// Set the override with fallback.
{{ .Params.url | default $fallback_url }}

[nick-mon1]

Thanks for the comments team!

• @sarah-sch The link is now fixed for federalist.
• @mejiaj I've simplified the logic with your suggestion.

[sarah-sch]

Looks good!

[mejiaj]

Looks good, tested all links in services pages.

[ToniBonittoGSA]

w00t!