Refactor templates markup #7411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Removed duplicate `grid-container` classes and replaced with one top parent - [x] Removed un-necessary `grid-row` classes when not needed (events/single.html) - [x] Removed un-necessary `div` tags - [x] Improved header spacing on events landing pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes un-necessary grid tags, classes and duplicate grid styles to simplify template markup.
Preview
Link to Preview
Solution
grid-containerclasses and replaced with one top parentgrid-rowclasses when not needed (events/single.html)divtagsLayout Enhancements
events/list.html
Removed equal spacing for header
authors/list.html
Increased spacing below button
Increased spacing above name
authors/terms.html
Increased spacing above title
How To Test
Dev Checklist