Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-5123: Prepare for Ruby upgrade to 3.1.4 #249

Merged
merged 4 commits into from Apr 30, 2024

Conversation

luisgmetzger
Copy link
Contributor

@luisgmetzger luisgmetzger commented Apr 25, 2024

Summary

Checklist

Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the ⚠️ :warning: emoji and explain why the step was not completed.

Functionality Checks

  • You have merged the latest changes from the target branch (usually main) into your branch.

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.

  • Automated checks pass. If Code Climate checks do not pass, explain reason for failures:

Process Checks

  • You have specified at least one "Reviewer".

@luisgmetzger luisgmetzger requested a review from ddzz April 25, 2024 19:31
@luisgmetzger luisgmetzger marked this pull request as draft April 25, 2024 19:32
@luisgmetzger luisgmetzger marked this pull request as ready for review April 25, 2024 19:33
.circleci/config.yml Outdated Show resolved Hide resolved
@luisgmetzger luisgmetzger requested a review from ddzz April 25, 2024 19:37
ddzz
ddzz previously approved these changes Apr 25, 2024
Copy link
Contributor

@ddzz ddzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lorawoodford lorawoodford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisgmetzger luisgmetzger changed the title SRCH-5123: Update Ruby version to 3.1.4 SRCH-5123: Prepare for Ruby upgrade to 3.1.4 Apr 25, 2024
@luisgmetzger luisgmetzger merged commit 7361b60 into GSA:main Apr 30, 2024
2 checks passed
@luisgmetzger luisgmetzger deleted the SRCH-5123 branch April 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants