3708 address historical federal awards with missing additional award identification #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing-additional-award-identification
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #658 |
|
Terraform plan for dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.dev.cloudfoundry_app.postgrest will be updated in-place
!~ resource "cloudfoundry_app" "postgrest" {
!~ docker_image = "ghcr.io/gsa-tts/fac/postgrest@sha256:58a897e8349f3b6a13810ae87751295841f7da1ce68e5f12a18948538fa49837" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:4b903ac223ea5f583bd870a328a3cf54d19267e5b5abfff896863b37f7cb68b6"
id = "5de6f04c-52e0-400f-961a-16243b1c7c9a"
name = "postgrest"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.dev.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 4 more similar warnings elsewhere)✅ Plan applied in Deploy to Development and Management Environment #658 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6aef691 |
backend/census_historical_migration/workbooklib/federal_awards.py
Outdated
Show resolved
Hide resolved
backend/census_historical_migration/workbooklib/federal_awards.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
sambodeme
commented
May 13, 2024
backend/census_historical_migration/workbooklib/federal_awards.py
Outdated
Show resolved
Hide resolved
sambodeme
commented
May 13, 2024
backend/census_historical_migration/workbooklib/federal_awards.py
Outdated
Show resolved
Hide resolved
phildominguez-gsa
previously approved these changes
May 13, 2024
…missing-additional-award-identification
…itional-award-identification' of github.com:GSA-TTS/FAC into 3708-address-historical-federal-awards-with-missing-additional-award-identification
phildominguez-gsa
previously approved these changes
May 13, 2024
phildominguez-gsa
approved these changes
May 13, 2024
sambodeme
deleted the
3708-address-historical-federal-awards-with-missing-additional-award-identification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some historical reports failed the first round of migration due to missing additional award identification. Upon investigation, it was discovered that the failure was due to invalid characters associated with the additional identification (value contains =""516084" instead of 516084) in the audit.AWARDIDENTIFICATION field in the database. This prevented the code from properly generating the awards workbook and hence from properly validating the data. The solution applied here was to add logic that sanitizes the audit.AWARDIDENTIFICATION values by removing leading
=""and trailing"for Excel.How to test
audit.AWARDIDENTIFICATIONvalues.audit.AWARDIDENTIFICATIONfield value by adding=""and trailing"(for instance, change123to `=""123"``.For extra points, you may try to create from scratch an audit report and submit it from this PR branch to confirm that process works as expected.
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.