New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting CLUSTERNAME transformation tracking, gsa_migration validation #3823
Conversation
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #657 |
Terraform plan for dev No changes. Your infrastructure matches the configuration.
❌ Plan not applied in Deploy to Development and Management Environment #657 (Plan has changed) |
Minimum allowed coverage is Generated by 🐒 cobertura-action against d72060e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration flag =False
should be passed here https://github.com/GSA-TTS/FAC/blob/sk/track_all_records/backend/audit/views/audit_info_form_view.py#L96
Need a unit test for this change in test_validators.py.
Closes: #3817
Follow up for #3785, #3723
Description:
Testing:
PR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)git status | grep migrations
. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrations
to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.