New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing missing ZIPCODE, CPAZIPCODE in historical audits #3808
Conversation
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #659 |
Terraform plan for dev No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #659 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against ad86bf9 |
@@ -32,6 +32,9 @@ def check_for_gsa_migration_keyword(ir): | |||
"contains_chart_or_table", | |||
"is_minimis_rate_used", | |||
"compliance_requirement", | |||
"auditee_zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we only track workbook fields (i.e., named ranges). auditee_zip
and auditor_zip
are part of general_information
section. This should go here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Closes #3808
In this PR:
ZIPCODE
and/orCPAZIPCODE
fields in the elecauditheaders and eleccpas tables, which (correctly) fail our validations.auditee_zip
andauditor_zip
tovalidate_use_of_gsa_migration_keyword
Testing:
ZIPCODE
andCPAZIPCODE
, or clear one that already existshistoric_data_migrator
on that audit and it should migrate without issueauditee_zip
andauditor_zip
in the dissemination_general table should be "GSA_MIGRATION"CPAZIPCODE
, or clear one that already exists7628,"243753201823516","2016","145144","","",FAC OVERRIDE,FAC OVERRIDE,FAC OVERRIDE,CA,"",FAC OVERRIDE,FAC OVERRIDE,"2133184987","",FAC OVERRIDE,"999999999"
historic_data_migrator
on that audit and it should migrate without issueaddress_zipcode
in the dissemination_secondary_auditor table should be "GSA_MIGRATION"PR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)git status | grep migrations
. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrations
to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.