Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address historical federal awards with missing additional award identification #3708

Closed
Tracked by #3364
phildominguez-gsa opened this issue Apr 19, 2024 · 0 comments · Fixed by #3828
Closed
Tracked by #3364

Address historical federal awards with missing additional award identification #3708

phildominguez-gsa opened this issue Apr 19, 2024 · 0 comments · Fixed by #3828
Assignees
@sambodeme
Labels
eng

Comments

@phildominguez-gsa
Copy link
Contributor

phildominguez-gsa commented Apr 19, 2024 •
edited by sambodeme

Some historical reports failed the first round of migration due to missing additional award identification. Upon investigation, it was discovered that the failure was due to invalid characters associated with the additional identification (value contains =""516084" instead of 516084) in the audit.AWARDIDENTIFICATION field in the database. This prevented the code from properly generating the awards workbook and hence from properly validating the data. The solution applied here was to add logic that sanitizes the audit.AWARDIDENTIFICATION values by removing leading =" and trailing " for Excel.

  • Error message: Missing additional award identification
  • Example: 176362, 2020
  • Related section: Federal awards
@phildominguez-gsa phildominguez-gsa mentioned this issue Apr 19, 2024
Open
@phildominguez-gsa phildominguez-gsa changed the title Address error "Missing additional award identification" Address historical federal awards with missing additional award identification Apr 23, 2024
@sambodeme sambodeme self-assigned this May 10, 2024
@sambodeme sambodeme added the eng label May 10, 2024
sambodeme added a commit that referenced this issue May 10, 2024
@sambodeme
#3708 Add Logic to sanitize the additional award identification data
ce7dc89
@sambodeme sambodeme linked a pull request May 10, 2024 that will close this issue
3708 address historical federal awards with missing additional award identification #3828
Merged
14 tasks
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@sambodeme @phildominguez-gsa
3708 address historical federal awards with missing additional award …
3ef243c 
…identification (#3828)

* #3708 Add Logic to sanitize the additional award identification data

* Code improvement

* Update backend/census_historical_migration/workbooklib/federal_awards.py

Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>

* Update backend/census_historical_migration/workbooklib/federal_awards.py

Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>

* Update backend/census_historical_migration/workbooklib/federal_awards.py

* Update backend/census_historical_migration/workbooklib/federal_awards.py

* Updated comment

---------

Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambodeme sambodeme

Labels
eng
Projects
FAC
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3708 address historical federal awards with missing additional award identification GSA-TTS/FAC
2 participants
@sambodeme @phildominguez-gsa