Set colormap bounds to data range for better contrast #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311 by scaling the colormap to the range of the data, improving contrast.
Current Behavior
With the range of the data set to [0, num people] there is low color contrast when there is less difference in availability between possible meeting times. E.g. if for all times only about half of people are available, the colors will all be close to the center of the colormap's full range.
A pro of this behavior is that it makes it obvious if there is low consensus about the best times.
However, since the goal of crab.fit is to help people decide on the best time, that should probably be the priority. Scaling the colormap to the range of the data makes this easier.
Screenshots
At the worst times, 2/9 people are available. At best it's 5/9. Without scaling the colormap to match the data it's difficult to see the difference between the times.
Before:
After:
