Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added _sparse_orthogonal_conditional #2027

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

Conversation

sc336
Copy link
Contributor

@sc336 sc336 commented Dec 5, 2022

Draft PR for taking the GPflow components from this GPflux PR into GPflow. The work is based on this paper.

============================

PR type: bugfix / enhancement / new feature / doc improvement

Related issue(s)/PRs:

Summary

Proposed changes

  • ...
  • ...
  • ...

What alternatives have you considered?

Minimal working example

# Put your example code in here

Release notes

Fully backwards compatible: yes / no

If not, why is it worth breaking backwards compatibility:

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black+isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 98.09% // Head: 98.04% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (d6c38b8) compared to base (cce56f8).
Patch coverage: 40.00% of modified lines in pull request are covered.

❗ Current head d6c38b8 differs from pull request most recent head 66a0b8c. Consider uploading reports for the commit 66a0b8c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2027      +/-   ##
===========================================
- Coverage    98.09%   98.04%   -0.06%     
===========================================
  Files           93       93              
  Lines         5263     5268       +5     
===========================================
+ Hits          5163     5165       +2     
- Misses         100      103       +3     
Impacted Files Coverage Δ
gpflow/conditionals/conditionals.py 87.50% <40.00%> (-12.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant