Clean up broadcasting conditionals #1618
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roadcasting_conditionals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type: enhancement
Summary
The independent separate multi-output conditional relied on tf.map_fn and a lot of reshaping. This PR makes the base_conditional broadcast over independent Kuu etc, which allows us to delete most of the code in independent separate multi-output conditional.
Note that this PR currently is in draft mode; there may be a bunch of unnecessary transposes, and we haven't yet checked whether this degrades accuracy in any way.
PR checklist
make format)make check-all)Release notes
Fully backwards compatible: yes
Commit message (for release notes):