New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize implementation of Gaussian expectations of Gaussian kernels #1607
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't double check all the maths, but if the tests pass I'm happy to accept this PR.
kernels.SquaredExponential, | ||
InducingPoints, | ||
) | ||
@dispatch.expectation.register((Gaussian, DiagonalGaussian), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll have to run make format
to make the formatting checks pass in the tests.
kernels.SquaredExponential, | ||
InducingPoints, | ||
) | ||
@dispatch.expectation.register((Gaussian, DiagonalGaussian), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to run make format
to make the format checkers happy in the tests.
@st-- Just merged with the current |
PR type: Enhancement
Summary
Proposed changes$E_{p(x)}[k1(Z1, x) k2(x, Z2)]$ to support different kernels and different inducing locations.
Extend the existing implementation of Gaussian expectations of Gaussian kernels
Minimal working example
PR checklist
make format
)make check-all
)Release notes
Fully backwards compatible: yes