Testing of various C++20 features #1207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they DTRT without excessive promotion for ints, doubles, floats, etc...
Barely an improvement and still falls back to Qt if we don't have <bit>, but this is just a proving ground.
The errors actually ARE easier to read. Sure, it's a lot of words in
this training-wheels case.
gpsbabel/garmin_txt.cc:974:22: error: no matching function for call to 'FahrenheitToCelsius'
*temperature = FahrenheitToCelsius("booger");
^~~~~~~~~~~~~~~~~~~
gpsbabel/defs.h:92:3: note: candidate template ignored: constraints not satisfied [with T = const char *]
T FahrenheitToCelsius(T a) { return (a - 32.0) / 1.8;}
^
gpsbabel/defs.h:91:10: note: because 'const char *' does not satisfy 'integral'
requires std::integral<T> || std::floating_point<T>
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__concepts/arithmetic.h:30:20: note: because 'is_integral_v<const char *>' evaluated to false
concept integral = is_integral_v<_Tp>;
^
gpsbabel/defs.h:91:30: note: and 'const char *' does not satisfy 'floating_point'
requires std::integral<T> || std::floating_point<T>
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__concepts/arithmetic.h:39:26: note: because 'is_floating_point_v<const char *>' evaluated to false
concept floating_point = is_floating_point_v<_Tp>;
Better type safety from enum class. Less annoying repetition via using.
Open
…enty Why are there merges between mypushes?
tsteven4
reviewed
Nov 2, 2023
fmt.h
Outdated
| } ; | ||
|
|
||
| // It's present everywhere else, right? | ||
| #elif __has_include(<format.h>) |
There was a problem hiding this comment.
The standard header is <format>, not <format.h>.
https://en.cppreference.com/w/cpp/header/format
|
You had a bad merge on xcsv.cc. I think this is what you meant: |
tsteven4
reviewed
Nov 3, 2023
|
|
||
| // Fallback to the system version. | ||
| #elif __has_include(<format>) | ||
| # include <format.h> |
There was a problem hiding this comment.
Again, the system version is<format>
|
With the xcsv.cc I attached above, and actually including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of everything just to see how well C++20 is supported. This is just
a few commits for each major feature. If there's anything useful in this PR, I expect
to have to pick it apart and cherry pick as I can't imagine this whole PR going in as
one.
See related discussion on #1204.