Feature/povolny1/polar decomposition #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alculates the polar decomposition of a 3x3 square matrix
corbett5
reviewed
Mar 1, 2023
src/fixedSizeSquareMatrixOpsImpl.hpp
Outdated
| error += RRTMinusI[i][j] * RRTMinusI[i][j]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you want to error out (or at least return a signal) if it doesn't converge?
There was a problem hiding this comment.
What should I use to print an error message? Using LVARRAY_WARNING_IF() fails to compile since it calls std::cout.
There was a problem hiding this comment.
I'd either return the achieved tolerance or the number of iterations or just a boolean to indicate success or failure. Alternatively you can use LVARRAY_ERROR_IF which works on device to just kill the program.
|
Unit test is implemented and passing, I will make an accompanying PR for GEOSX soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the polar decomposition for real square 2x2 and 3x3 matrices using Higham's iterative algorithm. This is needed for some constitutive models and particularly a new hypoelastic update that I'm implementing.