Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register pressureGradient only for hybrid FVM (single phase) #3125

Merged
merged 8 commits into from
May 17, 2024

Conversation

paveltomin
Copy link
Contributor

No description provided.

@paveltomin paveltomin requested a review from dkachuma May 14, 2024 15:31
@paveltomin paveltomin self-assigned this May 14, 2024
@paveltomin paveltomin changed the title Register pressureGradient only for hybrid FVM Register pressureGradient only for hybrid FVM (single phase) May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 53.56%. Comparing base (7ace2fc) to head (00d0d04).

Files Patch % Lines
.../physicsSolvers/fluidFlow/SinglePhaseHybridFVM.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
- Coverage    53.57%   53.56%   -0.01%     
===========================================
  Files         1003     1003              
  Lines        85289    85297       +8     
===========================================
- Hits         45696    45693       -3     
- Misses       39593    39604      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CusiniM
Copy link
Collaborator

CusiniM commented May 15, 2024

In reality, it would be good if we could find a way to compute this also for tpfa. It's just harder to come up with a way to approximate it.

@paveltomin
Copy link
Contributor Author

In reality, it would be good if we could find a way to compute this also for tpfa. It's just harder to come up with a way to approximate it.

something like that?
image
@karimifard can confirm if that makes sense

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels May 15, 2024
@paveltomin paveltomin added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: ready for review labels May 15, 2024
@CusiniM
Copy link
Collaborator

CusiniM commented May 15, 2024

In reality, it would be good if we could find a way to compute this also for tpfa. It's just harder to come up with a way to approximate it.

something like that? image @karimifard can confirm if that makes sense

yeah, what's annoying is the number of derivatives that entails... I guess we will just lag the term.

@karimifard
Copy link
Contributor

In reality, it would be good if we could find a way to compute this also for tpfa. It's just harder to come up with a way to approximate it.

something like that? image @karimifard can confirm if that makes sense

yeah, what's annoying is the number of derivatives that entails... I guess we will just lag the term.

The formula should work for Cartesian grids but it's not clear to me it will work for non Cartesian unstructured grids. If I am not wrong, it is essentially a weighted average of face velocity, with the weights being distance to face times the face area, which is a volume. In the Cartesian case, these weights add up to the volume and the formula works but in general adding all the weights/volumes will be larger than the volume of the cell. So if we want to use something like (17) we need to adjust the cell volume, or maybe just average the face velocities (q/A). Another way to estimate the velocity inside the element is to use a least square approximation. I may have missed something...

@CusiniM
Copy link
Collaborator

CusiniM commented May 16, 2024

In reality, it would be good if we could find a way to compute this also for tpfa. It's just harder to come up with a way to approximate it.

something like that? image @karimifard can confirm if that makes sense

yeah, what's annoying is the number of derivatives that entails... I guess we will just lag the term.

The formula should work for Cartesian grids but it's not clear to me it will work for non Cartesian unstructured grids. If I am not wrong, it is essentially a weighted average of face velocity, with the weights being distance to face times the face area, which is a volume. In the Cartesian case, these weights add up to the volume and the formula works but in general adding all the weights/volumes will be larger than the volume of the cell. So if we want to use something like (17) we need to adjust the cell volume, or maybe just average the face velocities (q/A). Another way to estimate the velocity inside the element is to use a least square approximation. I may have missed something...

The least square approximation s what we use for the Mimetic. the annoying thing with tpfa was that we don't store the face velocities so to compute cell center values we would need to do another stencil loop coz we need the neighbors' pressures.

@CusiniM CusiniM merged commit 07d1ce3 into develop May 17, 2024
24 of 26 checks passed
@CusiniM CusiniM deleted the pt/pressure-grad-hybrid branch May 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants