Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate fluid models #3123

Merged
merged 13 commits into from
Jun 4, 2024
Merged

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented May 13, 2024

This PR activates some fluid models in MultiFluidSelector.hpp only for CPU builds. The issue is that when activated for CUDA builds, these extra models cause compilation failures for some of the GHA pipelines. These are therefore currently being activated only for non-device builds.

  • Some dangling debugging code is also cleaned up.
  • A unit test is activated to test the different fluid models.

@dkachuma dkachuma self-assigned this May 13, 2024
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI labels May 13, 2024
@dkachuma dkachuma marked this pull request as ready for review May 13, 2024 23:36
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.70%. Comparing base (0f53ecd) to head (9449600).

Files Patch % Lines
...onents/constitutive/fluid/multifluid/PVTDriver.cpp 50.00% 1 Missing ⚠️
...ompositional/models/NegativeTwoPhaseFlashModel.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3123   +/-   ##
========================================
  Coverage    53.70%   53.70%           
========================================
  Files         1010     1010           
  Lines        85637    85639    +2     
========================================
+ Hits         45990    45993    +3     
+ Misses       39647    39646    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkachuma dkachuma removed flag: requires rebaseline Requires rebaseline branch in integratedTests labels May 14, 2024
@dkachuma dkachuma removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels May 14, 2024
@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 21, 2024
@dkachuma dkachuma added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label May 22, 2024
@paveltomin paveltomin added flag: no rebaseline Does not require rebaseline and removed flag: ready for review labels Jun 4, 2024
@paveltomin paveltomin merged commit 5418d08 into develop Jun 4, 2024
25 of 26 checks passed
@paveltomin paveltomin deleted the feature/dkachuma/activate-fluid-models branch June 4, 2024 21:27
@dkachuma dkachuma mentioned this pull request Jun 4, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants