Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests into ATS and adjust output naming #3120

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Add missing tests into ATS and adjust output naming #3120

wants to merge 22 commits into from
+52 −11

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented May 10, 2024 •
edited

Also disable restarting for cases with EmbeddedSurfaceGenerator, since its postRestartInitialization function is not implemented (documented in #3126)

@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label May 10, 2024
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.69%. Comparing base (967b5e4) to head (0c82fec).

Files Patch % Lines
...ers/surfaceGeneration/EmbeddedSurfaceGenerator.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
- Coverage    53.69%   53.69%   -0.01%     
===========================================
  Files         1010     1010              
  Lines        85649    85651       +2     
===========================================
  Hits         45991    45991              
- Misses       39658    39660       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin marked this pull request as draft May 13, 2024 14:43
Pavel Tomin and others added 2 commits May 13, 2024 09:48
@paveltomin paveltomin marked this pull request as ready for review May 13, 2024 14:57
@paveltomin paveltomin self-assigned this May 13, 2024
@paveltomin paveltomin changed the title add two missing tests and adjust output naming add missing tests and adjust output naming May 13, 2024
@paveltomin paveltomin changed the title add missing tests and adjust output naming Add missing tests and adjust output naming May 13, 2024
@paveltomin paveltomin changed the title Add missing tests and adjust output naming Add missing tests into ATS and adjust output naming May 13, 2024
jafranc
jafranc approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got all expected failure :)
Thanks for this update. 👍

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: ready for review labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafranc jafranc jafranc approved these changes

@CusiniM CusiniM Awaiting requested review from CusiniM

Assignees

@paveltomin paveltomin

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paveltomin @jafranc