Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure solver fluid updates #3116

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented May 8, 2024

No description provided.

@dkachuma dkachuma self-assigned this May 8, 2024
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs DO NOT MERGE ! labels May 8, 2024
@dkachuma dkachuma marked this pull request as ready for review May 8, 2024 18:51
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 224 lines in your changes are missing coverage. Please review.

Project coverage is 53.55%. Comparing base (44684e1) to head (55810e5).

Files Patch % Lines
.../fluidFlow/DirichletFaceBasedAssemblyKernelFVM.hpp 0.00% 191 Missing ⚠️
...idFlow/DirichletFaceBasedAssemblyKernelFVMImpl.hpp 0.00% 13 Missing ⚠️
...sicsSolvers/fluidFlow/kernels/MultiFluidUpdate.cpp 67.85% 9 Missing ⚠️
...rs/fluidFlow/wells/CompositionalMultiphaseWell.cpp 82.22% 8 Missing ⚠️
...Solvers/fluidFlow/kernels/MultiFluidUpdateImpl.hpp 66.66% 2 Missing ⚠️
...sSolvers/fluidFlow/CompositionalMultiphaseBase.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3116      +/-   ##
===========================================
- Coverage    53.58%   53.55%   -0.03%     
===========================================
  Files         1003     1007       +4     
  Lines        85189    85167      -22     
===========================================
- Hits         45645    45614      -31     
- Misses       39544    39553       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkachuma dkachuma removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 13, 2024
@dkachuma dkachuma marked this pull request as draft May 13, 2024 17:27
@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 13, 2024
@dkachuma dkachuma marked this pull request as ready for review May 13, 2024 19:02
@dkachuma dkachuma marked this pull request as draft May 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs DO NOT MERGE !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant