Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2853 with a flag #3108

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

liyangrock
Copy link

This PR addressed issue #2853 by adding a flag to determine if the lagging update should be applied to the fracture stencil weights.

This was done specifically for the hydrofracture solver, as it was observed that issue #2853 was currently causing performance degradation only for this particular solver. Therefore, the flag was exclusively introduced to the hydrofracture solver.

For further discussions related to issue #2853, please see #2922 .

@liyangrock liyangrock mentioned this pull request May 3, 2024
@paveltomin paveltomin requested review from karimifard, CusiniM and paveltomin and removed request for karimifard May 3, 2024 13:27
@paveltomin paveltomin added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels May 3, 2024
@Guotong-Ren
Copy link
Contributor

To understand, is the flow area in fracture from last time step? Do you have any thoughts on evaluation of the time step size impact on the solution?

@liyangrock
Copy link
Author

liyangrock commented May 4, 2024

To understand, is the flow area in fracture from last time step? Do you have any thoughts on evaluation of the time step size impact on the solution?

Indeed, the calculation of fracture stencil weights is performed using the hydraulicAperture from the previous time step. I have conducted a comparison between dt=0.25s and dt=5.0s for viscosity-dominated KGD cases. The resulting net pressure and aperture at the mouth are displayed below.

The difference between the numerical result (with dt=0.25s) and the analytical result can be attributed to the fact that the numerical scenario employs a low toughness value (i.e., 1e4), whereas the analytical solution does not incorporate any toughness.

kgd_verification

The input files are included here.
kgdVis.zip

@paveltomin paveltomin self-requested a review May 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants