Implement Temperature-dependent Solid Volumetric Heat Capacity #3088

sytuannguyen · 2024-04-22T08:27:52Z

This PR is part of the Non-Linear Thermal Behavior project. It aims to implement the linear temperature dependent of the solid volumetric specific heat capacity.

C = C0 + dC_dT * (T-T0)

where C0 is the reference solid volumetric heat capacity at the reference temperature T0 and dC_dT is the gradient of the volumetric heat capacity w.r.t. temperature. They are both provided by users in XML input files.

The existing linear constitutive model corresponds to the particular case with dC_dT = 0.

…icHeatCapacity

… model

herve-gross

Thank you for this contribution and for documenting it properly.

…icHeatCapacity

…' of https://github.com/GEOS-DEV/GEOS into feature/sytuan/temperatureDependentSpecificHeatCapacity

…icHeatCapacity

codecov · 2024-05-30T03:28:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.57%. Comparing base (85f6d0c) to head (88dce23).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3088   +/-   ##
========================================
  Coverage    53.57%   53.57%           
========================================
  Files         1003     1003           
  Lines        85297    85305    +8     
========================================
+ Hits         45695    45703    +8     
  Misses       39602    39602

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jhuang2601 · 2024-06-04T20:07:17Z

src/coreComponents/constitutive/solid/SolidInternalEnergy.cpp

+    setDescription( "Reference solid volumetric heat capacity [J/(kg.K)]" );
+
+  registerWrapper( viewKeyStruct::dVolumetricHeatCapacity_dTemperatureString(), &m_dVolumetricHeatCapacity_dTemperature ).
+    setInputFlag( InputFlags::REQUIRED ).


Suggested change

setInputFlag( InputFlags::REQUIRED ).

setApplyDefaultValue( 0.0 ).

jhuang2601 · 2024-06-04T20:08:38Z

src/coreComponents/unitTests/fluidFlowTests/testThermalCompMultiphaseFlow.cpp

@@ -109,7 +109,8 @@ char const * xmlInput =
                        referencePressure="0.0"
                        compressibility="1.0e-9" />
      <SolidInternalEnergy name="rockInternalEnergy"
-                           volumetricHeatCapacity="1.95e6"
+                           referenceVolumetricHeatCapacity="1.95e6"
+                           dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:09:02Z

src/coreComponents/unitTests/fluidFlowTests/testThermalSinglePhaseFlow.cpp

@@ -94,7 +94,8 @@ char const * xmlInput =
                        referencePressure="0.0"
                        compressibility="1.0e-9" />
      <SolidInternalEnergy name="rockInternalEnergy"
-                           volumetricHeatCapacity="1.95e6"
+                           referenceVolumetricHeatCapacity="1.95e6"
+                           dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:10:34Z

inputFiles/singlePhaseFlow/3D_10x10x10_thermalCompressible_base.xml

@@ -63,7 +63,8 @@

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.95e6"
+      referenceVolumetricHeatCapacity="1.95e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:10:58Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

-      volumetricHeatCapacity="4.56e6"
+      name="rockInternalEnergy_linear"
+      referenceVolumetricHeatCapacity="4.56e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:11:35Z

inputFiles/thermalMultiphaseFlow/co2_thermal_2d.xml

@@ -104,7 +104,8 @@
      compressibility="1.0e-9"/>
    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.95e6"
+      referenceVolumetricHeatCapacity="1.95e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:13:54Z

inputFiles/thermalSinglePhaseFlowFractures/egsCollab_thermalFlow/egsCollab_thermalFlow_base.xml

@@ -80,7 +80,8 @@

     <SolidInternalEnergy
       name="rockInternalEnergy"
-       volumetricHeatCapacity="2.3345e6"
+       referenceVolumetricHeatCapacity="2.3345e6"
+       dVolumetricHeatCapacity_dTemperature="1e6"


dVolumetricHeatCapacity_dTemperature for this case should be zero (default value)?

Suggested change

dVolumetricHeatCapacity_dTemperature="1e6"

jhuang2601 · 2024-06-04T20:14:04Z

inputFiles/thermalSinglePhaseFlowFractures/fractureMatrixThermalFlow_base.xml

@@ -47,7 +47,8 @@

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.672e5"
+      referenceVolumetricHeatCapacity="1.672e5"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:14:13Z

inputFiles/thermoPoromechanics/ThermoPoroElastic_consolidation_base.xml

@@ -49,7 +49,8 @@
    <!-- SPHINX_INTERNAL_ENERGY -->            
    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.672e5"
+      referenceVolumetricHeatCapacity="1.672e5"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:14:24Z

inputFiles/thermoPoromechanics/ThermoPoroElastic_staircase_co2_smoke.xml

@@ -188,7 +188,8 @@

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.95e6"
+      referenceVolumetricHeatCapacity="1.95e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:14:33Z

inputFiles/thermoPoromechanicsFractures/ThermoPoroElastic_base.xml

@@ -37,7 +37,8 @@

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.672e5"
+      referenceVolumetricHeatCapacity="1.672e5"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:15:33Z

inputFiles/thermoPoromechanicsFractures/ThermoPoroElastic_efem-edfm_eggModel_small.xml

@@ -219,7 +219,8 @@

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.672e5"
+      referenceVolumetricHeatCapacity="1.672e5"
+      dVolumetricHeatCapacity_dTemperature="1e6"


dVolumetricHeatCapacity_dTemperature for this case should be zero (default value)?

Suggested change

dVolumetricHeatCapacity_dTemperature="1e6"

jhuang2601 · 2024-06-04T20:15:45Z

inputFiles/wellbore/CasedThermoElasticWellbore_ImperfectInterfaces_base.xml

@@ -168,19 +168,22 @@
    <!-- SPHINX_HeatCapacityProperties -->
    <SolidInternalEnergy
      name="casingInternalEnergy"
-      volumetricHeatCapacity="1.375e6"
+      referenceVolumetricHeatCapacity="1.375e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:15:55Z

inputFiles/wellbore/CasedThermoElasticWellbore_ImperfectInterfaces_base.xml

      referenceTemperature="0"
      referenceInternalEnergy="0"/>

    <SolidInternalEnergy
      name="cementInternalEnergy"
-      volumetricHeatCapacity="4.2e6"
+      referenceVolumetricHeatCapacity="4.2e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:16:06Z

inputFiles/wellbore/CasedThermoElasticWellbore_ImperfectInterfaces_base.xml

      referenceTemperature="0"
      referenceInternalEnergy="0"/>

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="4.56e6"
+      referenceVolumetricHeatCapacity="4.56e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:16:18Z

inputFiles/wellbore/CasedThermoElasticWellbore_base.xml

@@ -110,19 +110,22 @@
    <!-- SPHINX_HeatCapacityProperties -->
    <SolidInternalEnergy
      name="casingInternalEnergy"
-      volumetricHeatCapacity="1.375e6"
+      referenceVolumetricHeatCapacity="1.375e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:16:27Z

inputFiles/wellbore/CasedThermoElasticWellbore_base.xml

      referenceTemperature="0"
      referenceInternalEnergy="0"/>

    <SolidInternalEnergy
      name="cementInternalEnergy"
-      volumetricHeatCapacity="4.2e6"
+      referenceVolumetricHeatCapacity="4.2e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:16:36Z

inputFiles/wellbore/CasedThermoElasticWellbore_base.xml

      referenceTemperature="0"
      referenceInternalEnergy="0"/>

    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="4.56e6"
+      referenceVolumetricHeatCapacity="4.56e6"
+      dVolumetricHeatCapacity_dTemperature="0"


Suggested change

dVolumetricHeatCapacity_dTemperature="0"

jhuang2601 · 2024-06-04T20:17:37Z

inputFiles/wellbore/ThermoPoroElasticWellbore_base.xml

@@ -73,7 +73,8 @@
    <!-- SPHINX_HeatCapacityProperties -->
    <SolidInternalEnergy
      name="rockInternalEnergy"
-      volumetricHeatCapacity="1.89e6"
+      referenceVolumetricHeatCapacity="1.89e6"
+      dVolumetricHeatCapacity_dTemperature="1e6"


dVolumetricHeatCapacity_dTemperature for this case should be zero (default value)?

Suggested change

dVolumetricHeatCapacity_dTemperature="1e6"

jhuang2601 · 2024-06-04T20:18:59Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

+      solidModelName="nullSolid"
+      porosityModelName="rockPorosity"
+      permeabilityModelName="rockPerm"
+      solidInternalEnergyModelName="rockInternalEnergy_linear"/>


suggest to use the name as rockInternalEnergy_constant

jhuang2601 · 2024-06-04T20:19:51Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

      solidModelName="nullSolid"
      porosityModelName="rockPorosity"
      permeabilityModelName="rockPerm"
-      solidInternalEnergyModelName="rockInternalEnergy"/>
+      solidInternalEnergyModelName="rockInternalEnergy_nonLinear"/>


suggest to use the name as rockInternalEnergy_linear

jhuang2601 · 2024-06-04T20:20:56Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

@@ -51,12 +51,22 @@

 	<!-- SPHINX_SolidInternalEnergy -->
    <SolidInternalEnergy
-      name="rockInternalEnergy"
-      volumetricHeatCapacity="4.56e6"
+      name="rockInternalEnergy_linear"


suggest to use the name as rockInternalEnergy_constant

jhuang2601 · 2024-06-04T20:21:44Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

      referenceTemperature="0"
      referenceInternalEnergy="0"/>
 	<!-- SPHINX_SolidInternalEnergyEnd -->

+    <!-- SPHINX_SolidInternalEnergy_nonLinear -->
+    <SolidInternalEnergy
+      name="rockInternalEnergy_nonLinear"


suggest to use the name as rockInternalEnergy_linear

jhuang2601 · 2024-06-04T20:25:47Z

src/coreComponents/schema/schema.xsd

@@ -5162,12 +5162,14 @@ If you want to do a three-phase simulation, please use instead wettingIntermedia
 		<xsd:attribute name="name" type="groupName" use="required" />
 	</xsd:complexType>
 	<xsd:complexType name="SolidInternalEnergyType">
+		<!--dVolumetricHeatCapacity_dTemperature => Derivative of the solid volumetric heat capacity w.r.t. temperature [J/(m^3.K^2)]-->
+		<xsd:attribute name="dVolumetricHeatCapacity_dTemperature" type="real64" use="required" />


Suggested change

<xsd:attribute name="dVolumetricHeatCapacity_dTemperature" type="real64" use="required" />

<xsd:attribute name="dVolumetricHeatCapacity_dTemperature" type="real64" default="0.0" />

sytuannguyen added 2 commits April 22, 2024 09:42

implement temperature-dependent volumetric heat capacity

9ff8c15

Merge branch 'develop' into feature/sytuan/temperatureDependentSpecif…

477330f

…icHeatCapacity

sytuannguyen added type: feature New feature or request flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input labels Apr 22, 2024

sytuannguyen requested review from herve-gross and jhuang2601 April 22, 2024 08:27

sytuannguyen self-assigned this Apr 22, 2024

sytuannguyen and others added 7 commits April 23, 2024 10:17

update XML files

cb429f5

add xml for non linear solid internal energy

bc5e7c7

add Python script for validating the non-linear solid internal energy…

681e045

… model

update SolidInternalEnergy.rst

7f0f827

add data for validation

a154920

update the validation document

02507d7

wordsmithing

6e7694d

herve-gross approved these changes Apr 24, 2024

View reviewed changes

sytuannguyen added 6 commits May 3, 2024 09:31

Merge branch 'develop' into feature/sytuan/temperatureDependentSpecif…

a32886b

…icHeatCapacity

change xmls

9ad0b18

Merge branch 'feature/sytuan/temperatureDependentSpecificHeatCapacity…

36a18bd

…' of https://github.com/GEOS-DEV/GEOS into feature/sytuan/temperatureDependentSpecificHeatCapacity

Merge branch 'develop' into feature/sytuan/temperatureDependentSpecif…

6a97d7d

…icHeatCapacity

update unit tests

fd9c380

update an integrated test

22890cb

sytuannguyen marked this pull request as ready for review May 30, 2024 02:22

sytuannguyen added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 30, 2024

sytuannguyen added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label May 30, 2024

uncrustify style

88dce23

jhuang2601 reviewed Jun 4, 2024

View reviewed changes

jhuang2601 mentioned this pull request Jun 4, 2024

Enable temperature dependent thermal properties #2535

Open

2 tasks

jhuang2601 added the flag: ready for review label Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Temperature-dependent Solid Volumetric Heat Capacity #3088

Implement Temperature-dependent Solid Volumetric Heat Capacity #3088

sytuannguyen commented Apr 22, 2024 •

edited

herve-gross left a comment

codecov bot commented May 30, 2024 •

edited

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024 •

edited

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024 •

edited

jhuang2601 Jun 4, 2024

jhuang2601 Jun 4, 2024

	setInputFlag( InputFlags::REQUIRED ).
	setApplyDefaultValue( 0.0 ).

	<xsd:attribute name="dVolumetricHeatCapacity_dTemperature" type="real64" use="required" />
	<xsd:attribute name="dVolumetricHeatCapacity_dTemperature" type="real64" default="0.0" />

Implement Temperature-dependent Solid Volumetric Heat Capacity #3088

Are you sure you want to change the base?

Implement Temperature-dependent Solid Volumetric Heat Capacity #3088

Conversation

sytuannguyen commented Apr 22, 2024 • edited

herve-gross left a comment

Choose a reason for hiding this comment

codecov bot commented May 30, 2024 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhuang2601 Jun 4, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhuang2601 Jun 4, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sytuannguyen commented Apr 22, 2024 •

edited

codecov bot commented May 30, 2024 •

edited

jhuang2601 Jun 4, 2024 •

edited

jhuang2601 Jun 4, 2024 •

edited