Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring flow StackVariables to use DerivOffset #3085

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jafranc
Copy link
Contributor

@jafranc jafranc commented Apr 19, 2024

As it is used in isothermalCompositionalMultiphaseFVMKernel or MultifluidBase, derivative offset helps readability and would made extension easier.

The refactoring though left out for now

  • dTrans_dDisJump as this derivative is multidimensional
  • Hybrid Kernels with pressure both at cell center and face.

@jafranc jafranc requested a review from CusiniM April 19, 2024 15:21
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 53.25%. Comparing base (65064b0) to head (2147533).

Files Patch % Lines
...ls/SinglePhasePoromechanicsConformingFractures.hpp 0.00% 2 Missing ⚠️
...nels/SinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 2 Missing ⚠️
...malSinglePhasePoromechanicsConformingFractures.hpp 0.00% 1 Missing ⚠️
...ermalSinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3085   +/-   ##
========================================
  Coverage    53.25%   53.25%           
========================================
  Files          989      989           
  Lines        83542    83543    +1     
========================================
+ Hits         44493    44494    +1     
  Misses       39049    39049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jafranc jafranc self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant