-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move particle generators to their own folder #3068
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3068 +/- ##
===========================================
+ Coverage 53.19% 53.23% +0.03%
===========================================
Files 989 992 +3
Lines 83646 83768 +122
===========================================
+ Hits 44498 44592 +94
- Misses 39148 39176 +28 ☔ View full report in Codecov by Sentry. |
I've tried to split the Still remains this question of
which tend to indicate that it's not so bad since currently
are known to fail. Is there any chance that you can handle this refactoring? |
@TotoGaz I pulled your branch and I'm trying to take a look at why the single particle test is failing. However, I'm having some trouble building your branch. I get the follolwing error:
|
Hi @cmcrook5 thanks you for your actions! |
Hello @cmcrook5 did you manage to compile the branch? |
@TotoGaz yes, I was able to after updating the TPLs, thanks. |
Remove the dependency (and the transitive dependencies) to
SpatialPartition
in themesh/generators
"package".