Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reviewed] [Boids Movement] Fix typo of VelocityX and VelocityY being swapped #1272

Merged
merged 3 commits into from May 8, 2024
Merged

[Reviewed] [Boids Movement] Fix typo of VelocityX and VelocityY being swapped #1272

merged 3 commits into from May 8, 2024

Conversation

tristanbob
Copy link
Contributor

Should also fix potential problems with "avoid object" action by setting the correct TrajectorySpeed.

@tristanbob
Fix typo of VelocityX and VelocityY being swapped
14250bf 
Should also fix potential problems with "avoid object" action by setting the correct TrajectorySpeed.
@tristanbob tristanbob requested a review from D8H May 6, 2024 04:57
@tristanbob tristanbob self-assigned this May 6, 2024
@tristanbob tristanbob requested a review from a team as a code owner May 6, 2024 04:57
@tristanbob tristanbob added the 🔄 Extension update An update for an existing extension label May 6, 2024
@D8H
Copy link
Contributor

D8H commented May 6, 2024 •
edited

It looks like only the labels and descriptions are inverted. Please, modify these instead of renaming the functions as it probably breaks a formula.

Should also fix potential problems with "avoid object" action by setting the correct TrajectorySpeed.

Can you explain?

@tristanbob
Copy link
Contributor Author

It looks like only the labels and descriptions are inverted. Please, modify these instead of renaming the functions as it probably breaks a formula.

Sure, I re-installed the previous version and changed the name and descriptions (instead of editing the functions).

Should also fix potential problems with "avoid object" action by setting the correct TrajectorySpeed.

Can you explain?

The VelocityX and VelocityY expressions are used by the "AvoidPosition" action. I thought that perhaps these were used in reverse, but I don't understand the function. If this looks correct to you, then you can ignore my comment about this.

image

D8H
D8H approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@D8H D8H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this fix!

@tristanbob tristanbob merged commit 024a593 into main May 8, 2024
4 checks passed
@tristanbob tristanbob deleted the boids-velocity-typo branch May 8, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D8H D8H D8H approved these changes

Assignees

@tristanbob tristanbob

Labels
🔄 Extension update An update for an existing extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tristanbob @D8H