Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reviewed] [Camera shake] Enable shaking for all layers by default #1213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

D8H
Copy link
Contributor

@D8H D8H commented Mar 9, 2024

Demo

  • TODO

@D8H D8H added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Mar 9, 2024
@D8H D8H self-assigned this Mar 9, 2024
@D8H D8H added this to Needs review in Extensions review via automation Mar 9, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Errors were detected in this submission:


❌ 1 Error found in extension 'CameraShake':

  ⟶ ❌ [JavaScript disallowed properties]: Found disallowed properties in extension 'CameraShake':
{
  allowedProperties: [
    'makeUuid',           'rgbToHex',
    'rgbOrHexToRGBColor', 'rgbToHexNumber',
    'hexNumberToRGB',     'hexToRGBColor',
    'copyArray',          'staticArray',
    'staticArray2',       'staticObject',
    'toDegrees',          'toRad',
    'random',             'randomFloat',
    'randomFloatInRange', 'randomInRange',
    'randomWithStep',     'evtTools',
    'Variable',           'RuntimeObject',
    'Logger',             '_cameraShakeExtension'
  ],
  disallowedProperty: '__CameraShake3D',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw'
  ],
  disallowedProperty: 'getAllLayerNames',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Extensions review
  
Needs review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant