Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite snapshot] Handle 3D layers #1179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CorporateDog
Copy link

Updated the 'RenderLayer' and 'RenderScene' functions to handle 3D objects and camera positioning better.

@CorporateDog CorporateDog requested a review from a team as a code owner February 21, 2024 16:41
@CorporateDog
Copy link
Author

The initial set of CircleCI tests failed, due to my use of the 'gdjs' global object.

If there's a better global object for me to attach my persisted objects to ('window' maybe?) please let me know.

@D8H
Copy link
Contributor

D8H commented Feb 21, 2024

Thank you for submitting an extension update.

If you need to keep some kind of state, you can add it to gdjs._renderToSprite. It's the namespace already used by this extension.

RenderToSprite: {
gdjsAllowedProperties: [
'_renderToSprite',
// Used for better autocomplete
'SpriteRuntimeObject',
],
gdjsEvtToolsAllowedProperties: [],
runtimeSceneAllowedProperties: [
// Used for rendering
'getRenderer',
// Used to update culling before rendering
'_updateLayersPreRender',
'_updateObjectsPreRender',
],
javaScriptObjectAllowedProperties: [],
},

You may find more details in these documentations:

@D8H D8H added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Feb 21, 2024
@D8H D8H changed the title Updated Extension: Sprite Snapshot [Sprite snapshot] Handle 3D layers Feb 21, 2024
@D8H D8H added this to Needs review in Extensions review via automation Feb 21, 2024
…jects and camera positioning better.

*Added tweak for global objects, so that they use the RenderToSprite namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Extensions review
  
Needs review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants