Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move e2e tests into separate crate #1374

Merged
merged 11 commits into from May 14, 2024

Conversation

segfault-magnet
Copy link
Contributor

@segfault-magnet segfault-magnet commented May 11, 2024

A different crate forces e2e tests to only use what was exported through fuels.

Part of an ongoing effort to stabilize the sdk.

Closes: #1093

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@segfault-magnet segfault-magnet added the tech-debt Improves code quality or safety label May 11, 2024
@segfault-magnet segfault-magnet self-assigned this May 11, 2024
MujkicA
MujkicA previously approved these changes May 12, 2024
Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I'm wondering about.
Thanks for the effort 🚀

packages/fuels-core/Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have left some small nits

.gitignore Outdated Show resolved Hide resolved
Forc.toml Outdated Show resolved Hide resolved
e2e/Cargo.toml Show resolved Hide resolved
@segfault-magnet segfault-magnet enabled auto-merge (squash) May 14, 2024 12:07
@segfault-magnet segfault-magnet enabled auto-merge (squash) May 14, 2024 12:08
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks again for taking this up!

@segfault-magnet segfault-magnet merged commit b9421db into master May 14, 2024
42 checks passed
@segfault-magnet segfault-magnet deleted the refactor/move_e2e_tests branch May 14, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests to be moved from fuels
5 participants