Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update wallet.rs in-line BIP doc #1370

Merged
merged 4 commits into from May 10, 2024
Merged

chore: update wallet.rs in-line BIP doc #1370

merged 4 commits into from May 10, 2024

Conversation

K1-R1
Copy link
Contributor

@K1-R1 K1-R1 commented May 9, 2024

This PR makes a small addition to the in-line docs of new_from_mnemonic_phrase_with_path to clarify that it is not restricted to BIP32 derivation paths only.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Closes #1369

@K1-R1 K1-R1 added the documentation Improvements or additions to documentation label May 9, 2024
@K1-R1 K1-R1 self-assigned this May 9, 2024
@hal3e hal3e changed the title Update wallet.rs in-line BIP doc chore: update wallet.rs in-line BIP doc May 9, 2024
@K1-R1 K1-R1 enabled auto-merge (squash) May 10, 2024 06:19
digorithm
digorithm approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@K1-R1 K1-R1 merged commit 49c25d4 into master May 10, 2024
40 checks passed
@K1-R1 K1-R1 deleted the K1-R1/update-BIP-docs branch May 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@K1-R1 K1-R1

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Update wallet.rs in-line BIP doc
4 participants
@K1-R1 @digorithm @Br1ght0ne @hal3e