Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix revert id #1368

Merged
merged 3 commits into from May 10, 2024
Merged

bug: fix revert id #1368

merged 3 commits into from May 10, 2024
+240 −166

Conversation

segfault-magnet
Copy link
Contributor

closes: #1331

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@segfault-magnet segfault-magnet added the bug Something isn't working label May 8, 2024
@segfault-magnet segfault-magnet self-assigned this May 8, 2024
hal3e
hal3e approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Love the test macros

digorithm
digorithm approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this so quickly!

@segfault-magnet segfault-magnet merged commit d5e74fc into master May 10, 2024
41 checks passed
@segfault-magnet segfault-magnet deleted the bug/simulation_revert_reason branch May 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

Assignees

@segfault-magnet segfault-magnet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect (generic) error propagation upon a .simulate()
4 participants
@segfault-magnet @digorithm @Salka1988 @hal3e