Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): replace version variables with hardcoded verisons #1301

Merged
merged 14 commits into from May 21, 2024
Merged

fix(docs): replace version variables with hardcoded verisons #1301

merged 14 commits into from May 21, 2024

Conversation

Br1ght0ne
Copy link
Member

While #1168 is unfinished, we should hardcode the used versions in the documentation URLs.

Please note that this PR:

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Br1ght0ne Br1ght0ne added the documentation Improvements or additions to documentation label Mar 20, 2024
@Br1ght0ne Br1ght0ne self-assigned this Mar 20, 2024
@Br1ght0ne Br1ght0ne enabled auto-merge (squash) March 20, 2024 15:37
MujkicA
MujkicA previously approved these changes Mar 29, 2024
View reviewed changes
@Br1ght0ne Br1ght0ne dismissed stale reviews from segfault-magnet and MujkicA via ab75cc3 May 9, 2024 12:09
MujkicA
MujkicA previously approved these changes May 10, 2024
View reviewed changes
@Br1ght0ne Br1ght0ne merged commit 7f43e07 into master May 21, 2024
43 checks passed
@Br1ght0ne Br1ght0ne deleted the oleksii/hardcode-docs-versions branch May 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salka1988 Salka1988 Salka1988 approved these changes

@MujkicA MujkicA MujkicA approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@iqdecay iqdecay Awaiting requested review from iqdecay

@hal3e hal3e Awaiting requested review from hal3e hal3e is a code owner

Assignees

@Br1ght0ne Br1ght0ne

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Br1ght0ne @Salka1988 @MujkicA @segfault-magnet @hal3e