test: enable testing against a live node #1257
Conversation
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
| } | ||
| let provider = Provider::connect(TESTNET_NODE_URL) | ||
| .await | ||
| .expect("Should be able to connect to {TESTNET_NODE_URL}"); |
There was a problem hiding this comment.
I suspect you wanted the value to be interpolated here:
| .expect("Should be able to connect to {TESTNET_NODE_URL}"); | |
| .unwrap_or_else(|_| panic!("Should be able to connect to {TESTNET_NODE_URL}")); |
Note
why not expect(&format!(...))? See this clippy lint
| @@ -35,3 +35,4 @@ which = { workspace = true, default-features = false } | |||
| default = ["fuels-accounts", "std"] | |||
| std = ["fuels-accounts?/std", "fuels-core/std"] | |||
| fuel-core-lib = ["fuel-core"] | |||
| test-against-live-node = [] | |||
There was a problem hiding this comment.
I'd rather we don't introduce a feature if we don't have to. Since the test code compiles always (unlike the case with full sway type paths tests) I'd rather we make the decision to target the test net based on an env variable:
if env!(TARGET_TEST_NET) ... This way our internal testing approach doesn't leak into user features.
There was a problem hiding this comment.
I went this direction because that was what transpired in the previous discussion here. Happy to change it though.
| @@ -85,6 +86,44 @@ pub async fn launch_custom_provider_and_get_wallets( | |||
| Ok(wallets) | |||
| } | |||
|
|
|||
| pub async fn connect_to_testnet_node_and_get_wallets( | |||
There was a problem hiding this comment.
I wouldn't put these in the test helpers crate. The test helpers contain stuff we deem to be useful to all users. This is more of our internal desire to test the testnet. Why limit our users to stuff like:
- no more than 3 wallets
- the test net must be the official one from fuel (URL hardcoded)
- the env variables must be strictly the ones we set here (TEST_WALLET_SECRET_KEY_*)
- etc
I'd rather we move this helper to our e2e tests and have it be private there since they are the only reason this exists.
This PR closes #1135 by adding a new feature
test-against-live-nodewhich can be turned on to run some integration tests against a live node.For some of them, to avoid SqueezedOutTransaction errors, I added a
sleepcall.