Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests to be moved from fuels #1093

Closed
segfault-magnet opened this issue Aug 19, 2023 · 1 comment · Fixed by #1374
Closed

e2e tests to be moved from fuels #1093

segfault-magnet opened this issue Aug 19, 2023 · 1 comment · Fixed by #1374
Assignees
Labels
tech-debt Improves code quality or safety

Comments

@segfault-magnet
Copy link
Contributor

By having the e2e tests inside fuels we're prone to useing stuff from fuels dependencies rather than fuels itself. This then leads to issues like "we didn't know xyz hadn't been reexported throught fuels. The test worked fine" only to find that we included xyz from something like fuel-tx in the test.

This cannot be avoided as long as the tests are in fuels because we cannot make prod deps unavailable for the integration tests.

One idea is to have a new e2e (or whatever) package that would contain all the e2e tests. The package itself should not be published. The tests there would only be dependent on fuels.

@segfault-magnet segfault-magnet added the tech-debt Improves code quality or safety label Aug 19, 2023
@Br1ght0ne Br1ght0ne self-assigned this Aug 19, 2023
@iqdecay
Copy link
Contributor

iqdecay commented Aug 21, 2023

Very smart find! Will probably prevent some embarassing issues haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
3 participants