feat: Preserve message proofs post-regenesis #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7245764.
xgreenx
requested changes
May 13, 2024
There was a problem hiding this comment.
FuelBlockMerkleData and FuelBlockMerkleMetadata should be on-chain data because all newly produced blocks should be connected to old blocks. Otherwise, it is impossible to withdraw money.
We need to update the Genesis block as well, not to use zero prev_root. It should be the root that contains all old blocks.
| assert_eq!(nonces.len(), 1); | ||
|
|
||
| for nonce in nonces { | ||
| let proof = core |
There was a problem hiding this comment.
We need to use the proof and validate it like in the can_get_message_proof test.
Because the proof returned here is not usable. The user is still unable to withdraw his funds because new blocks are not connected to old blocks.
Reapply "Populate prev root from last block before regenesis" This reverts commit aaa061c.
xgreenx
reviewed
May 13, 2024
tests/tests/regenesis.rs
Outdated
|
|
||
| // Then | ||
| assert_eq!(nonces.len(), 1); | ||
|
|
There was a problem hiding this comment.
for block_height in message_block_height+1..latest_block_after_regenesis {
}
xgreenx
previously approved these changes
May 15, 2024
xgreenx
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets:
This PR adds block Merkle data and metadata to the list of migrated tables during regenesis. Creating a snapshot now inlcudes the
FuelBlockMerkleDataandFuelBlockMerkleMetadatatables. Loading the snapshot writes theFuelBlockMerkleDataandFuelBlockMerkleMetadatasnapshot tables to theOldFuelBlockMerkleDataandOldFuelBlockMerkleMetadatadatabase tables respectively (2 new tables added to the off-chain database).When querying for a message proof, we check the block height of the query. If the requested message proof is for block height at or above the regenesis block height, we continue to use the on-chain database for data lookups. If it is instead lower than the regenesis block height, we then check the off-chain database for the
Oldtables.This PR also refactors the block proof logic to rely on a new trait called
DatabaseMerklizedBlockswhich provides an interface for querying block related Merkle data. Specifically, this includes retrieving Merkle block data and metadata, and loading the block Merkle tree. TheDatabaseMessageProofis now implemented by default for any type that implements this trait, which include the on-chain and off-chain databases that define the corresponding tables.This PR is intended to not be a breaking change.
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]