Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linter warnings and some headers #995

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

conao3
Copy link
Contributor

@conao3 conao3 commented Nov 22, 2019

Hi! I found many linter warnings so I try to solve them.
But many warnings remained. I fix easy warnings only.

Warnings

Lisp symbol ‘regexp-opt’ should appear in quotes (emacs-lisp-checkdoc)
Lisp symbol ‘regexp-quote’ should appear in quotes (emacs-lisp-checkdoc)
Lisp symbol ‘text-mode’ should appear in quotes (emacs-lisp-checkdoc)
Name lisp should appear capitalized as Lisp (emacs-lisp-checkdoc)

Headers

Some headers wrote Created date as -- format. Follow smartparens.el.

Fix header comment to follow smartparens.el

Remove unneeded version/keyword/url comment header (should refer main smartparens.el).

smartparens.el Outdated
sp-wrap-mark
sp-last-wrapped-region
sp-pair-overlay-list
sp-wrap-overlays
sp-wrap-tag-overlays
sp-last-operation
sp-previous-point
)
sp-previous-point)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paren here is intentionally on next line so diffs are nicer: if one thing is added the diff is "+1" instead of "-1/+2".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change.

@conao3
Copy link
Contributor Author

conao3 commented Jan 19, 2020

I reverted your mentioned diff. There are any other concerns?

@Fuco1
Copy link
Owner

Fuco1 commented Jan 20, 2020

I'll need to do another review, it's a huuuge change set. Thanks for your patience!

@conao3
Copy link
Contributor Author

conao3 commented Jan 20, 2020

Thanks reply! It's just a ping. I thank you very much for maintaining many packages.

@conao3
Copy link
Contributor Author

conao3 commented Mar 10, 2020

Any concerns?

@Hi-Angel
Copy link
Contributor

Hi-Angel commented Feb 21, 2024

The list of warnings that is in the PR description should go instead to the commit message body. Because once it's merged, it's highly unlikely anybody's gonna read the PR, but people do read git-log.


With that said, @Fuco1 ping? I also noted that smartparens produces various warnings with native compilation, I think this PR would be a good start (even though I presume it doesn't fix byte-compilation warnings)

@Fuco1 Fuco1 mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants