New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linter warnings and some headers #995
base: master
Are you sure you want to change the base?
Conversation
smartparens.el
Outdated
sp-wrap-mark | ||
sp-last-wrapped-region | ||
sp-pair-overlay-list | ||
sp-wrap-overlays | ||
sp-wrap-tag-overlays | ||
sp-last-operation | ||
sp-previous-point | ||
) | ||
sp-previous-point) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paren here is intentionally on next line so diffs are nicer: if one thing is added the diff is "+1" instead of "-1/+2".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change.
I reverted your mentioned diff. There are any other concerns? |
I'll need to do another review, it's a huuuge change set. Thanks for your patience! |
Thanks reply! It's just a ping. I thank you very much for maintaining many packages. |
Any concerns? |
The list of warnings that is in the PR description should go instead to the commit message body. Because once it's merged, it's highly unlikely anybody's gonna read the PR, but people do read git-log. With that said, @Fuco1 ping? I also noted that smartparens produces various warnings with native compilation, I think this PR would be a good start (even though I presume it doesn't fix byte-compilation warnings) |
Hi! I found many linter warnings so I try to solve them.
But many warnings remained. I fix easy warnings only.
Warnings
Headers
Some headers wrote Created date as -- format. Follow smartparens.el.
Fix header comment to follow smartparens.el
Remove unneeded version/keyword/url comment header (should refer main smartparens.el).