Add support for clojure-ts-mode #1185
Conversation
|
Marking as draft until this is resolved: clojure-emacs/clojure-ts-mode#36 |
|
Hmm, do we even need to iterate the derived modes if there's no special smartparens configuration for them? Seems excessive to me. Perhaps the legacy config is from the days before all modes were folded in |
|
@bbatsov thanks for the feedback. I can give it a try in the next days without all the derived modes. |
|
I removed all the derived modes. As far as I can tell, everything works fine in buffers using the derived modes. |
kommen
changed the title
smartparens.el
Outdated
| clojurec-mode | ||
| clojurescript-mode | ||
| clojurex-mode |
There was a problem hiding this comment.
This needs to stay there because sp-list-modes is checked literally not taking into account how modes derive from one another.
The question is whether it should, but right now it doesn't, so this will actually remove these modes from being marked as "lisp" modes.
| @@ -44,7 +44,7 @@ | |||
| (defvar sp-clojure-prefix "\\(?:[@`'#~,_?^]+\\)" | |||
| "Prefix used in `sp-sexp-prefix' for clojure modes.") | |||
|
|
|||
| (dolist (mode '(clojure-mode clojurescript-mode clojurec-mode cider-repl-mode)) | |||
There was a problem hiding this comment.
This sp-sexp-prefix setting takes the modes literally, not taking into account how modes derive from one another. So removing them here will break things unfortunatelly.
This reverts commit fa0d1ca.
|
@Fuco1 I have reverted the commit which removed the modes from the lists. Would you prefer me to force push it out? |
clojure-ts-modeis developed as a distinct alternative toclojure-mode, as discussed here: clojure-emacs/clojure-mode#640 (comment)