Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sp-forward-symbol and sp-backward-symbol skip comments. #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pierre-rouleau
Copy link

The change diff seems bigger that it really is. The change include:

  • A new function: sp-inside-comment that returns non-nil when point is inside comment
  • Modification of the sp-forward-symbol`: add form inside the cond form to move forward while in comment in the first loop.
  • Modification of the sp-backward-symbol : add form inside the cond form to move backward while in comment in the first loop.

@Fuco1
Copy link
Owner

Fuco1 commented Nov 1, 2021

Well, this works like that on purpose. If we want such a feature it would need to be behind a feature flag because this is backward incompatible behaviour change. Some 3rd party code might depend on this.

@pierre-rouleau
Copy link
Author

Then perhaps it'd be good to document the current behaviour. I'll look at the feature flags and see if I can add that under feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants