Conflit resolution #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianmat
reviewed
Feb 1, 2024
| @@ -30,7 +30,7 @@ export class EntitiesService { | |||
|
|
|||
| const entityKey = this.getEntityKey(actor, key) | |||
|
|
|||
| return await this.dataServiceFactory.getService().set(entityKey, value) | |||
| return await this.dataServiceFactory.getService().set(entityKey, value,new Date().getTime()) | |||
There was a problem hiding this comment.
Here and everywhere else, please enable prettier and use the config in the repo to fix code style issues.
christianmat
reviewed
Feb 1, 2024
| @@ -5,13 +5,13 @@ import { DataService } from '../data-service/data-service.interface' | |||
| export class SqliteService implements OnModuleInit, DataService { | |||
| private db = null | |||
| private sqlite3 = require('sqlite3') | |||
| constructor() {} | |||
| constructor() { } | |||
|
|
|||
| async onModuleInit() { | |||
| try { | |||
| this.db = new this.sqlite3.Database('./database.sqlite') | |||
There was a problem hiding this comment.
Update SQL to add the column if the table already exists.
|
Over-all looks good. Please add some unit tests as well. You can see how to set that up with Nest.js here: https://docs.nestjs.com/fundamentals/testing |
Ensured kv table includes a timestamp column for better conflict resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces conflict resolution mechanisms in both
RedisandSQLiteservices. It adds timestamp-based conflict detection and resolution inRedisService, ensuring data integrity during concurrent updates. Similarly, forSqliteService, the code now includes handling for conflicts using timestamps