Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the button's border - Added disableTappingShadow property, to remove the ElevatedButton's shadow upon tapping in case the user requires a flat look
Frezyx
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Hello @JaseElder !
Thanks a lot for this contribution
Can we fix review issues before merge ?
lib/src/group_button_body.dart
Outdated
Comment on lines
66
to
67
| final List<BoxShadow> unselectedShadow; | ||
| final bool? disableTappingShadow; |
There was a problem hiding this comment.
I think it would be better if we could provide a default field shadowColor for more customization.
|
I'm not sure whether I've done the right thing with this PR edit, but it looks like the new changes are there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0)