This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Formatted device information #1568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait, that is not the move... i just think that code like gbDevice.addDeviceInfo(new GenericItem("SUPPORTS_VIBRATION: ", String.valueOf(supportsExtendedVibration()))); just doesn't feel right... would it be reasonable to add an extra field named Lebel, where one could put the actual Label to display? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made proprietary Device information show up like "INFO: abc" instead of "INFOabc".
That problem could be avoided by using "INFO: " as the information key/name, but that seems to miss the point of a hashlist for me...